Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added dispose() method to Reflector and Refractor classes #22932

Merged
merged 2 commits into from
Dec 2, 2021
Merged

added dispose() method to Reflector and Refractor classes #22932

merged 2 commits into from
Dec 2, 2021

Conversation

LR17
Copy link
Contributor

@LR17 LR17 commented Dec 1, 2021

Description

Reflector and Refractor classes from examples are missing a dispose() method to dispose the internal render target.
See discussion on forum

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 1, 2021 •
edited
Loading

As mentioned in the forum please also honor the internal material in dispose().

@LR17
Copy link
Contributor Author

LR17 commented Dec 1, 2021

Done!

@Mugen87 Mugen87 added this to the r136 milestone Dec 1, 2021
@mrdoob mrdoob merged commit 71e9ea0 into mrdoob:dev Dec 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented Dec 2, 2021

Thanks!

@joshuaellis joshuaellis mentioned this pull request Dec 4, 2021
Closed
9 tasks
@LR17 LR17 deleted the dispose branch April 7, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r136
Development

Successfully merging this pull request may close these issues.
3 participants
@LR17 @Mugen87 @mrdoob