Fix collada transparency handling. #22907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the official collada specification, the opaque attribute for the transparent object is optional, and the default value is 'A_ONE'.
Mugen87
approved these changes
Nov 29, 2021
|
/cc @BSpolantis |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The modification made in #22679 broke the transparency handling, because some models now appear fully transparent, but they shouldn't. According to the official collada specification, the opaque attribute for the transparent object is optional, and the default value is 'A_ONE'.
Now I implemented this behaviour, and also removed the code added in #22679. I don't fully understand how the previous solution would solve the problem of missing opaque value, but it wasn't correct according to the specification.