Teleport Player if Out of Bounds in games_fps #22877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello, this PR affects examples/games_fps.html. If the player jumps out of bounds (which is possible with jump velocity of 15), then the player capsule and player camera will be teleported back to their original vectors.
Please let me know if there's anything else I can add :)
EDIT: Adding a Githack link: https://rawcdn.githack.com/Uueuuuuu/three.js/8ee5d09c58ef88c2a95d18ad6800ce8c966fa8ef/examples/games_fps.html
EDIT no.2 : Should I not hardcode the vectors on line 427 and 428? They are referenced from the original on line 102.