Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layers: Add isEnabled(). #22825

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Layers: Add isEnabled(). #22825

merged 2 commits into from
Nov 16, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 13, 2021

Related issue: #20979

Description

Second attempt to add a method that allow to test for single layers.

@Mugen87 Mugen87 mentioned this pull request Nov 13, 2021
Closed
@WestLangley
Copy link
Collaborator

Returns true if the given layer is enabled.

Maybe layers.isEnabled( channel ) would be better nomenclature.

@mrdoob
Copy link
Owner

mrdoob commented Nov 15, 2021

Maybe layers.isEnabled( channel ) would be better nomenclature.

That sounds good to me 👍

@mrdoob mrdoob added this to the r135 milestone Nov 15, 2021
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 15, 2021

Updated the PR.

@Mugen87 Mugen87 changed the title Layers: Add testLayer(). Layers: Add isEnabled(). Nov 16, 2021
@mrdoob mrdoob merged commit 609e1ef into mrdoob:dev Nov 16, 2021
@mrdoob
Copy link
Owner

mrdoob commented Nov 16, 2021

Thanks!

@joshuaellis joshuaellis mentioned this pull request Nov 21, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r135
Development

Successfully merging this pull request may close these issues.
3 participants
@Mugen87 @WestLangley @mrdoob