Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Consistent documentation of "return this". #22799

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 8, 2021

Related issue: Fixed #22333.

Description

Methods which return this are now consistently documented with the this annotation.

The type of a class is only returned when a method actually returns a new object e.g. clone().

@Mugen87 Mugen87 changed the title Docs: Consistent use of "return this". Docs: Consistent documentation of "return this". Nov 8, 2021
@Mugen87 Mugen87 added this to the r135 milestone Nov 8, 2021
@Mugen87 Mugen87 merged commit 7f00e65 into mrdoob:dev Nov 8, 2021
@mrdoob
Copy link
Owner

mrdoob commented Nov 8, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Inconsistency method return type this
2 participants