Update SSAARenderPass.js #22798
Merged
Update SSAARenderPass.js #22798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix file references
Mugen87
reviewed
Nov 8, 2021
| @@ -7,7 +7,7 @@ import { | |||
| UniformsUtils, | |||
| WebGLRenderTarget | |||
| } from '../../../build/three.module.js'; | |||
| import { Pass, FullScreenQuad } from '../postprocessing/Pass.js'; | |||
There was a problem hiding this comment.
This path is actually a leftover from the time when modules were generated from examples/js. It seems almost all post processing pass classes use ../postprocessing/Pass.js;right now.
Do you mind updating the other classes in examples/jsm/postprocessing, too?
There was a problem hiding this comment.
If you don't want to update the other passes, that's fine. We can still merge the PR and I do a clean up afterwards 👍 .
There was a problem hiding this comment.
Thank you for your reply. I found that many files have this path problem. It is not very convenient for me to deal with the content of the file code, but it does not affect the operation at all。
Mugen87
approved these changes
Nov 10, 2021
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix file references
Related issue: #XXXX
Description
A clear and concise description of what the problem was and how this pull request solves it.
This contribution is funded by Example.