WebGLRenderer: Add data-engine="three.js r${REVISION}" to the canvas element #22792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent idea |
Mugen87
approved these changes
Nov 6, 2021
|
@WestLangley suggested we could make it more human readable: 6056cbf |
mrdoob
changed the title
mrdoob
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I thought it would be a good idea to add a custom attribute to the canvas element (ie.
<canvas data-engine="three-135">) element to track the engine usage in the wild more easily.Seems like using
data-*is the way to go.Can anyone think of a reason why not to do this, or better ways or doing it?