Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGLoader: Make createShapes() retain curves #22778

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

georgpukk
Copy link
Contributor

The creation of new shapes and paths now works the same way as in shapePath.toShapes(). Instead of making them from points, it uses the curves array to preserve curve types.

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 3, 2021

@Ttommeke Does this look good to you?

@Ttommeke
Copy link
Contributor

Ttommeke commented Nov 3, 2021

Looks good to me! Might make the code run a fair bit faster.

@mrdoob mrdoob added this to the r135 milestone Nov 3, 2021
@mrdoob mrdoob merged commit a39e849 into mrdoob:dev Nov 3, 2021
@mrdoob
Copy link
Owner

mrdoob commented Nov 3, 2021

Thanks!

@joshuaellis joshuaellis mentioned this pull request Nov 7, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants