Update LWOLoader to more closely match LW native materials #22776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few minor adjustments to allow LWO files loaded into three.js to more closely match their appearance in the native LW app.
Updated SDK reference to latest 2019 file format specs.
Adjusted refractionRatio to more closely match LWO rendering.
Adjusted default metalness value for transparent items to preserve refraction.
Opacity set to 1 for refractive materials preserving visible refraction.
Roughness and Metalness values set to 1 when a texture is present. The texture modulates this value and anything less than 1 will limit the maximum possible value.