Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU: Clean up. #22768

Merged
merged 3 commits into from
Nov 1, 2021
Merged

WebGPU: Clean up. #22768

merged 3 commits into from
Nov 1, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Nov 1, 2021

Related issue: -

Description

Minor clean up in WebGPUNodeBuilder.

@Mugen87 Mugen87 requested a review from sunag November 1, 2021 10:06
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 1, 2021

@sunag One thing about WebGPUNodeBuilder.getTexture():

getTexture( textureProperty, uvSnippet, biasSnippet = null, shaderStage = this.shaderStage ) {

biasSnippet is not used in the method but required in WebGLNodeBuilder.getTexture(). On the other hand, shaderStage is required in WebGPUNodeBuilder but not in WebGLNodeBuilder. Is this going to change in the next time? If not I suggest to remove biasSnippet from NodeBuild.getTexture() and introduce builder-specific parameters instead.

@Mugen87 Mugen87 changed the title WebGPUNodeBuilder: Clean up. WebGPU: Clean up. Nov 1, 2021
@sunag
Copy link
Collaborator

sunag commented Nov 1, 2021

@sunag One thing about WebGPUNodeBuilder.getTexture():

What do you think of NodeBuilder.getTextureLod( )?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Nov 1, 2021

Sounds like step in the right direction! 👍

@Mugen87 Mugen87 added this to the r135 milestone Nov 1, 2021
@Mugen87 Mugen87 merged commit 640a0b5 into mrdoob:dev Nov 1, 2021
@mrdoob
Copy link
Owner

mrdoob commented Nov 1, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants