Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain flatness of 'values' parameter for Quaternion/VectorKeyframeT… #22766

Merged
merged 2 commits into from Nov 5, 2021
Merged

Explain flatness of 'values' parameter for Quaternion/VectorKeyframeT… #22766

merged 2 commits into from Nov 5, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2021

…rack ctor

Related issue: none

Description

Just in case someone else mistakenly assumes that values should be an array of, say, Vector3 or Quaternion objects instead of a flat array of their components. Seemed like a natural assumption considering the class names.

@Mugen87
Copy link
Collaborator

Mugen87 commented Nov 1, 2021

I would also update ColorKeyframeTrack otherwise people think values is an array of THREE.Color.

@ghost
Copy link
Author

ghost commented Nov 1, 2021

That's a good idea. I hadn't used ColorKeyframeTrack before, so I wasn't sure what kind of values it expected. Tested it out, confirmed it takes RGB components between 0 and 1 just like THREE.Color, and pushed an edit to its documentation.

@mrdoob mrdoob added this to the r135 milestone Nov 5, 2021
@mrdoob mrdoob merged commit 1ad67b0 into mrdoob:dev Nov 5, 2021
@mrdoob
Copy link
Owner

mrdoob commented Nov 5, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants