-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFExporter: Add KHR_materials_clearcoat support. #22761
Conversation
Changing it to |
Thanks! |
Yes, I do! |
Side note, when a glb with transmission is exported, @donmccurdy 's gltf validator throws And it's pointing to "KHR_materials_volume/attunationDistance" Maybe that also could be looked into while updating the thickness @Mugen87 |
It seems the |
@donmccurdy What do you recommend to fix this warning of glTF validator? Should we target a different default value for |
@Mugen87 The specification for The default attenuation distance for glTF is +Inf, implied when the if ( material.attenuationDistance > 0 ) {
extensionDef.attenuationDistance = material.attenuationDistance;
extensionDef.attenuationColor = material.attenuationColor.toArray();
} |
^KhronosGroup/glTF#2090 is resolved. |
Is there anything we have to do on our side? |
Related issue: Fixed #22751.
Description
Adds support of
KHR_materials_clearcoat
toGLTFExporter
.@mrdoob The PR also fixes an issue in context of
KHR_materials_volume
( #22214). Right now, the exporter always includes this extensions whenMeshPhysicalMaterial
is used because the default ofMeshPhysicalMaterial.thickness
is0.01
.According to the KHR_materials_volume spec, the extension always needs to be combined with another one like
KHR_materials_transmission
. The early-out condition ofGLTFMaterialsVolumeExtension
now checks for transmission usage instead.Besides, any reasons why the default of
MeshPhysicalMaterial.thickness
is0.01
? Changing it to0
seems more glTF conform.