WebGLRenderer: Disable usage of SRGB8_ALPHA8. #22759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2021
netpro2k
pushed a commit
to Hubs-Foundation/three.js
that referenced
this pull request
Nov 1, 2021
netpro2k
pushed a commit
to Hubs-Foundation/three.js
that referenced
this pull request
Nov 4, 2021
|
Thanks! |
11 tasks
sunag
added a commit
to sunag/three.js
that referenced
this pull request
Nov 24, 2021
mrdoob
pushed a commit
that referenced
this pull request
Nov 24, 2021
* optimize to bvec, ivec and uvec * greaterThan and lessThanEqual returns vector if need * ConvertNode: Convert a node type manually * add lessThanEqual, mix * support to manually vector convert: e.g: vec3 ( node ) * Support to sRGBToLinear * Sync with #22759
netpro2k
pushed a commit
to Hubs-Foundation/three.js
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: see #22631 (comment)
Description
Using
SRGB8_ALPHA8causes a performance overhead under Windows. According to the recent user feedback, it's probably better to pause the usage ofSRGB8_ALPHA8until https://bugs.chromium.org/p/chromium/issues/detail?id=1256340 is fixed and in prod.