Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: add parseAsync #22754

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

marcofugaro
Copy link
Contributor

Related issue: #19118 #22031

Description

GLTFLoader extends Loader, this means it inherits loadAsync.
However also the .parse() method of GLTFLoader is async, but there is not parseAsync in Loader since most loader parse syncronously.

This PR adds parseAsync to GLTFLoader to make it conform to other loaders such as ObjectLoader (#22031).

@mrdoob mrdoob added this to the r135 milestone Oct 29, 2021
@mrdoob mrdoob merged commit 24a2509 into mrdoob:dev Oct 29, 2021
@mrdoob
Copy link
Owner

mrdoob commented Oct 29, 2021

Thanks!

@joshuaellis joshuaellis mentioned this pull request Nov 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants