Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Rename frustum class for CSM. #22752

Merged
merged 1 commit into from
Oct 30, 2021
Merged

Examples: Rename frustum class for CSM. #22752

merged 1 commit into from
Oct 30, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 29, 2021

Related issue: https://discourse.threejs.org/t/csm-this-mainfrustum-split-is-not-a-function/31249

Description

This PR renames examples/jsm/csm/Frustum.js to examples/js/csm/CSMFrustum.js to avoid a name conflict with THREE.Frustum when using the global script version.

@Mugen87 Mugen87 added this to the r135 milestone Oct 29, 2021
Copy link
Collaborator

@gkjohnson gkjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrdoob mrdoob merged commit 7a46138 into mrdoob:dev Oct 30, 2021
@mrdoob
Copy link
Owner

mrdoob commented Oct 30, 2021

Thanks!

@joshuaellis joshuaellis mentioned this pull request Nov 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants