Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArcballControls: Derive from EventDispatcher. #22737

Merged
merged 3 commits into from
Oct 27, 2021
Merged

ArcballControls: Derive from EventDispatcher. #22737

merged 3 commits into from
Oct 27, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 27, 2021

Related issue: see #22733 (comment)

Description

This PR reverts the rename of scale() and also ensures ArcballControls is now derived from EventDispatcher.

@mrdoob mrdoob added this to the r134 milestone Oct 27, 2021
@mrdoob mrdoob merged commit cf17777 into mrdoob:dev Oct 27, 2021
@mrdoob
Copy link
Owner

mrdoob commented Oct 27, 2021

Thanks!

@CodyJasonBennett CodyJasonBennett mentioned this pull request Oct 28, 2021
Closed
@joshuaellis joshuaellis mentioned this pull request Nov 2, 2021
Closed
12 tasks
@Mugen87 Mugen87 mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r134
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @mrdoob