Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMREMGenerator: Fixed using compressed cubemaps. #22699

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 18, 2021

Related issue: https://discourse.threejs.org/t/compressed-envmaps-broken-past-r129-for-me-at-least/30924

Description

PMREMGenerator was not able so far to correctly detect compressed cube maps. A runtime error happened because _textureToCubeUV() picked the equirectangular shader although the cube map one should be used.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Oct 19, 2021

Merging this one for further testing on dev.

@Mugen87 Mugen87 merged commit 3b4b5a2 into mrdoob:dev Oct 19, 2021
@Mugen87 Mugen87 added this to the r134 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant