-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPU and NodeMaterial: WGSL Support #22688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did an approach entirely using flows for
NodeBuilder
for that we can removeShaderLib
approach and build material without a GLSL scheme inES6
with a similarGLSL
syntax.We removed support for
GLSL
andglslang.js
dependencies which had a reduction of922 KB
, including greater performance in shader compilation.The port of
GLSL
forWebGPU
is too experimental and caused numerous bugs only in my last implementations, unlike ofWGSL
that is the native shading language ofWebGPU
and is a bit more low-level allowing more control and optimization forShader Graphs
likeNodeMaterial
. A happy ending at last, in fact a new start :)Yet, much work in flow process can be done in
NodeMaterial
but I think that we first can mature the integration and provide more natives features supported ofThree.js
forWebGPU
like we did in:SkinningNode
, and adding basic support for analytic lights andPBR
usingShaderNode
( #22662 )Link
https://raw.githack.com/sunag/three.js/dev-wgsl/examples/index.html?q=webgpu
Related issue
ShaderNode - #22603
This contribution is funded by Google via Igalia.