Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Added webgl_loader_gltf_sheen. #22677

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Examples: Added webgl_loader_gltf_sheen. #22677

merged 1 commit into from
Oct 13, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 13, 2021

Related issue: #22674 (comment)

Description

This PR adds a new example webgl_loader_gltf_sheen and partial support for KHR_materials_sheen to GLTFLoader.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Oct 13, 2021 •
edited
Loading

Sidenote: Modulating the sheen property in the example has no effect. Our sheen BRDF only affects direct specular light so far (which is not glTF conform).

@mrdoob
Copy link
Owner

mrdoob commented Oct 13, 2021

Yes, I think @elalish was going to take a look at that.

@mrdoob mrdoob added this to the r134 milestone Oct 13, 2021
@mrdoob mrdoob merged commit ddccc27 into mrdoob:dev Oct 13, 2021
@mrdoob
Copy link
Owner

mrdoob commented Oct 13, 2021

Thanks!

@elalish
Copy link
Contributor

elalish commented Oct 13, 2021

Indeed, though I've been saying that for about a year now...😭 Might be better just to crib some shader code from the gltf_sample_viewer.

@Mugen87 Mugen87 mentioned this pull request Oct 20, 2021
Closed
@Mugen87 Mugen87 mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r134
Development

Successfully merging this pull request may close these issues.
3 participants
@Mugen87 @mrdoob @elalish