-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3MFLoader: fixed multiple build items refecering the same object bug #22663
Conversation
This is actually intended. Why do you think should it be different? |
Actually I thought it was not inteded. I had problems applying matrix transformations and as the build items reference the same buffer geometry both had the geometry updated. The first part was also intended? Because I came across some 3mf files with several build items referencing only one resource object, so I thought could be a problem. |
Do you mind sharing such a 3MF file for testing? When I remember correctly cloning should only be necessary in context of |
@Mugen87 Sorry for the delay, here is a file with one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this change is correct. I've checked the specification and indeed multiple items can refer to the same object resource by having the same value for objectid
.
Thanks! |
Multiple build items that reference the same resource object were being ignored as they referenced the same Object3d object. Also the build items meshes were using the same BufferGeometry's reference.