ColladaLoader: Re-added normal map parsing #22647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaicoianu
changed the title
Mugen87
approved these changes
Oct 6, 2021
|
Thanks! |
|
I wonder how it got lost though... |
Yeah I was digging through repo histories last night trying to figure that out too, but couldn't find the "missing" code anywhere except in my own project's copy. It may have been that when we switched from ColladaLoader to ColladaLoader2 (and renamed ColladaLoader2 to ColladaLoader), I noticed that it was broken and ported what had previously worked over, but it wasn't actually working, and I fixed it in my local copy but forgot to contribute. Guess it shows not a lot of people are using Collada anymore, glTF has definitely superseded it in wider use, but there's still a lot of old JanusVR content that uses it and I'm stubborn about keeping old content working 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #15391
Description
It seems that at some point, support for loading normal maps from Collada files was lost. This pull request restores that functionality to a working state, by parsing the material technique extras to handle the 'bump' option.