New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Fix CRLF problem. #22601

Merged

mrdoob merged 1 commit into mrdoob:dev from linbingquan:dev-editor-publish

Sep 28, 2021

Contributor

linbingquan commented Sep 28, 2021

Related issue: #---

Description

// doesn't work in CRLF case
content = content.replace( '\n\t\t\t/* edit button */\n', editButton ); 

// work in CRLF case and LF case
content = content.replace( '\t\t\t/* edit button */', editButton );


          Editor: Fix CRLF problem.

232a490

mrdoob added this to the r133 milestone

mrdoob merged commit fac5b5e into mrdoob:dev

Owner

mrdoob commented Sep 28, 2021

Thanks!

linbingquan deleted the dev-editor-publish branch

February 13, 2022 08:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet