Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect SVG <path> loader #22597

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix incorrect SVG <path> loader #22597

merged 1 commit into from
Sep 28, 2021

Conversation

qeeqez
Copy link
Contributor

@qeeqez qeeqez commented Sep 27, 2021

Related issue: #22511

Description

Somehow 'fill-rule' attribute was missing but actual functionality is in place

@mrdoob mrdoob added this to the r133 milestone Sep 28, 2021
@mrdoob mrdoob merged commit 7de6e29 into mrdoob:dev Sep 28, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 28, 2021

Thanks!

@qeeqez qeeqez deleted the fix-svg-loading branch September 28, 2021 09:28
@WestLangley
Copy link
Collaborator

This is a red flag... How could the three.js SVG examples have rendered correctly given this bug? The SVG files do not all use the "default" fill rule.

Are the test cases not sufficiently exhaustive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants