Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLNodeBuilder: Fix sRGBEncoding map using WebGL2 #22585

Merged
merged 2 commits into from
Sep 27, 2021
Merged

WebGLNodeBuilder: Fix sRGBEncoding map using WebGL2 #22585

merged 2 commits into from
Sep 27, 2021

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Sep 25, 2021

Description

  • Disable inline decode for sRGB textures in WebGL 2

This contribution is funded by Google via Igalia.

@sunag
Copy link
Collaborator Author

sunag commented Sep 27, 2021

This bug is evident in webgl_materials_standard_nodes example in map/colorNode of the material.

@mrdoob mrdoob added this to the r133 milestone Sep 27, 2021
@mrdoob mrdoob merged commit c69a667 into mrdoob:dev Sep 27, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 27, 2021

Thanks!

@sunag sunag deleted the dev-fix-textureencoding branch September 27, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r133
Development

Successfully merging this pull request may close these issues.
3 participants
@sunag @mrdoob @Mugen87