Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GLTFLoader: Clean up normalScale workaround #22584

Merged
merged 1 commit into from
Sep 30, 2021
Merged

GLTFLoader: Clean up normalScale workaround #22584

merged 1 commit into from
Sep 30, 2021

Conversation

donmccurdy
Copy link
Collaborator

Consolidating the special case from #11438 (comment) into one place.

@mrdoob mrdoob added this to the r133 milestone Sep 25, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 25, 2021

Seems like webgl_loader_gltf_transmission and webgl_loader_gltf_variants are failing?

@donmccurdy
Copy link
Collaborator Author

Hm, thanks! I'll take a look at that soon, it's fine for this to wait until r134 though.

@mrdoob mrdoob modified the milestones: r133, r134 Sep 27, 2021
@donmccurdy donmccurdy force-pushed the cleanup-gltfloader-tangents branch from 773b4c3 to f58de7f Compare September 30, 2021 05:40
@donmccurdy
Copy link
Collaborator Author

Fixed ✅

@mrdoob mrdoob modified the milestones: r134, r133 Sep 30, 2021
@mrdoob mrdoob merged commit 9223040 into mrdoob:dev Sep 30, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 30, 2021

Thanks!

@donmccurdy donmccurdy deleted the cleanup-gltfloader-tangents branch September 30, 2021 15:41
@0b5vr 0b5vr mentioned this pull request Oct 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r133
Development

Successfully merging this pull request may close these issues.
2 participants
@donmccurdy @mrdoob