RGBMLoader: Fix alerts in UPNG.js. #22578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Although we should start considering removing it though. I think Safari 15 no longer needs it? |
|
It seems RGBM is purposely used by developers in favor of other HDR formats (independently on iOS). I'm not sure we should remove it and force users to a migration task. IMO supporting RGBM in the library is not really a huge deal. |
|
I meant removing UPNG.js |
|
Oh, okay. Interesting point! I did not have the chance to test it but does iOS 15 still premulitplying alpha on PNG loading? |
|
Hmm, I remember testing this a few months ago with Safari Technology Preview and seemed like they finally solved it. I have not tried in the release yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
This PR fixes the lgtm.com alerts in
RGBMLoader. Since these issues came from theUPNG.jscode, I've reported them at the original repository. The maintainer quickly fixed them (one of them was actually a minor bug). We can now apply the code changes toRGBMLoader.photopea/UPNG.js#71