Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeMaterial: Node.type to Node.nodeType #22572

Merged
merged 2 commits into from
Sep 23, 2021
Merged

NodeMaterial: Node.type to Node.nodeType #22572

merged 2 commits into from
Sep 23, 2021

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Sep 23, 2021

Description

Both Object3D and Material uses .type property to returns the constructor.name.
I think that NodeMaterial can follow this standard.

Renames

  • Node.type -> Node.nodeType
  • Node.getType() -> Node.getNodeType()

New property

  • Node.type -> returns constructor.name

This contribution is funded by Google via Igalia.

@mrdoob mrdoob added this to the r133 milestone Sep 23, 2021
@mrdoob mrdoob merged commit b53dacf into mrdoob:dev Sep 23, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 23, 2021

Thanks!

@sunag sunag deleted the dev-nodetype branch September 28, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r133
Development

Successfully merging this pull request may close these issues.
3 participants
@sunag @mrdoob @Mugen87