Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure geometry helpers can use new clone() method. #22571

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Sep 22, 2021

Related issue: -

Description

This PR ensures that EdgesGeometry and WireframeGeometry are able to use the new BufferGeometry.clone() method.

IMO, it's a bit unlikely to clone both geometries since they depend on another object (like certain helper classes) but it's probably better to honor this use case for consistency.

@mrdoob mrdoob added this to the r133 milestone Sep 22, 2021
@mrdoob mrdoob merged commit 8ea885c into mrdoob:dev Sep 22, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 22, 2021

Thanks!

@0b5vr 0b5vr mentioned this pull request Oct 1, 2021
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants