WebGLRenderer: Compute .vertexTangents consistently. #22564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Sep 22, 2021
|
Thanks! |
donmccurdy
deleted the
bug-webglrenderer-vertextangents-invalidation
branch
|
would it make sense to refactor this out, to avoid divergence in the future? or comment for future devs perhaps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #22530
We need to compute program parameters consistently in these locations:
three.js/src/renderers/WebGLRenderer.js
Line 1518 in 7f6a099
three.js/src/renderers/webgl/WebGLPrograms.js
Line 231 in 7f6a099
That's easy to miss, and if they don't match can cause performance issues similar to the one identified in #22530. It'd be great if we can find a solution to #22530 that avoids having to compute these parameters in two locations. For now this PR just removes one case that may fall into that problem.