Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParametricGeometry: Remove from core. #22559

Merged
merged 2 commits into from
Sep 21, 2021
Merged

ParametricGeometry: Remove from core. #22559

merged 2 commits into from
Sep 21, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Sep 21, 2021

Related issue: Fixed #17381.

Description

The design of ParametricGeometry makes it complex to implement a secure serialization/deserialization.

Considering the very special character of the generator in general, I vote to move the class to the example directory.

@mrdoob mrdoob added this to the r133 milestone Sep 21, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 21, 2021

Hmm, the E2E tests seem to be failing. False alarm?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Sep 21, 2021

Two examples still used ParametricBufferGeometry instead of ParametricGeometry. Hence, I've overlooked them while searching for ParametricGeometry.

@mrdoob mrdoob merged commit a86bfbc into mrdoob:dev Sep 21, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 21, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Sep 21, 2021

Should we add something like this to Three.Legacy.js?

export function ParametricGeometry() {

	console.error( 'THREE.ParametricGeometry has been moved to /examples/jsm/geometries/ParametricGeometry.js' );
	return new BufferGeometry();

}

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Sep 21, 2021

Sounds good! Are you going to add this code or should I make another PR?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Sep 21, 2021

Never mind^^! c5bb543

@mrdoob
Copy link
Owner

mrdoob commented Sep 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization of ParametricGeometry, ParametricBufferGeometry contains unserializable function
2 participants