Iterable vectors

[ghost]

Description

All vectors (Vector2, Vector3 and Vector4) are now iterable.

const vec = new THREE.Vector3(5,5.7,8);

Math.min(...vec.toArray());//before

Math.min(...vec);//after

[Mugen87]

It seems the browser support for this syntax is well enough to give it a try. Builds do work and our eslint setup has no problems with this code, too.

[Mugen87]

Out of curiosity: How does Babel process such generators? Is it possible to produce ES5 builds with this syntax?

[Mugen87]

That is an important topic since there are three.js users which require ES5. And since we use generators the first time in the core, we should clarify this question.

[ghost]

Hey, that is an important question, thanks for the inquiry. A plugin is required for it to work with ES5, it's called regenerator-runtime. I tested a class with a custom iterator and destructuring it worked as expected.

Edit: This plugin is also required by an official babel package. Babel-runtime

[donmccurdy]

It appears that regenerator-runtime and @babel/runtime are meant to be used as production dependencies of a library like three.js; they are not devDependencies like most of the Babel toolchain. Currently three.js has no production dependencies, so I think it may be better to wait for features like this until after IE11 end-of-life.

[looeee]

it may be better to wait for features like this until after IE11 end-of-life.

Would adding this code break things for ES5 users even if they don't use it?

[Mugen87]

I would expect that IE11 is not able to parse JS code with generators. It would be a syntax error.

[mrdoob]

I think at this point we no longer support IE11 but I do worry about bundlers. Do bundlers support this well?

[donmccurdy]

Browserify works fine with them, so I'd expect newer bundlers like Webpack, Parcel, and Rollup to be OK as well. They are an ES6 feature, so not actually all that new.

[mrdoob]

Alright, lets see what happens 🤞

[mrdoob]

Thanks!