Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurvePath: .getPoint() honors optionalTarget #22533

Merged
merged 3 commits into from
Sep 13, 2021
Merged

CurvePath: .getPoint() honors optionalTarget #22533

merged 3 commits into from
Sep 13, 2021

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Sep 12, 2021

@Mugen87
Copy link
Collaborator

Mugen87 commented Sep 13, 2021 •
edited
Loading

Do you mind removing the following method from the respective doc pages (en/zh)?

https://threejs.org/docs/index.html#api/en/extras/core/CurvePath.getPoint
https://threejs.org/docs/index.html#api/zh/extras/core/CurvePath.getPoint

Now that the signature is equal to Curve.getPoint(), there is no need to document it separately anymore.

@ycw ycw requested a review from Mugen87 September 13, 2021 17:26
@ycw
Copy link
Contributor Author

ycw commented Sep 13, 2021

@Mugen87 e2e testing (0) timeouted, now what :) ?

@mrdoob
Copy link
Owner

mrdoob commented Sep 13, 2021

Running tests again...

@mrdoob mrdoob merged commit 9029dab into mrdoob:dev Sep 13, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 13, 2021

Thanks!

@mrdoob mrdoob added this to the r133 milestone Sep 13, 2021
@ycw ycw deleted the patch-1 branch September 13, 2021 19:53
@joshuaellis joshuaellis mentioned this pull request Sep 18, 2021
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Awaiting requested review from Mugen87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r133
Development

Successfully merging this pull request may close these issues.
3 participants
@ycw @Mugen87 @mrdoob