Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial: Rename SwitchNode -> SplitNode #22509

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Sep 8, 2021

Description

I think that this name would be better for the purpose of the node.

Example

// roughness is in G channel, metalness is in B channel
material.roughnessNode = new SplitNode( mpMapNode, 'g' );
material.metalnessNode = new SplitNode( mpMapNode, 'b' );

What do you think?

/ping @mrdoob @Mugen87

@mrdoob mrdoob added this to the r133 milestone Sep 8, 2021
@mrdoob mrdoob merged commit 7fb92f7 into mrdoob:dev Sep 8, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 8, 2021

Thanks!

@sunag sunag deleted the dev-switch-to-split branch September 10, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants