Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curve: Remove unneeded .normalize(). #22503

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Curve: Remove unneeded .normalize(). #22503

merged 1 commit into from
Sep 7, 2021

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Sep 7, 2021

the vec returning from getTangentAt() seems to be normalized already.

@mrdoob mrdoob added this to the r133 milestone Sep 7, 2021
@mrdoob mrdoob merged commit 305c488 into mrdoob:dev Sep 7, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 7, 2021

Thanks!

@ycw ycw deleted the patch-1 branch September 8, 2021 02:52
@Mugen87 Mugen87 changed the title kill double .normalize Curve: Remove unneeded .normalize(). Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r133
Development

Successfully merging this pull request may close these issues.
2 participants
@ycw @mrdoob