SAOPass: Fix depthTexture initialization.

[twastvedt]

Description

The constructor appears to expect the depthTexture argument to be a boolean:

this.supportsDepthTextureExtension = ( depthTexture !== undefined ) ? depthTexture : false;

If true, a texture is created:

		if ( this.supportsDepthTextureExtension ) {

			const depthTexture = new DepthTexture();
			depthTexture.type = UnsignedShortType;

			this.beautyRenderTarget.depthTexture = depthTexture;
			this.beautyRenderTarget.depthBuffer = true;

		}

the const above means the created depthTexture is not available when it is subsequently used, resulting in a value of true for the tDepth uniform:

this.saoMaterial.uniforms[ 'tDepth' ].value = ( this.supportsDepthTextureExtension ) ? depthTexture : this.depthRenderTarget.texture;

I believe it was intended instead to overwrite the argument value with the new depth texture.

This contribution is funded by Proving Ground.

[Mugen87]

the const above means the created depthTexture is not available when it is subsequently used, resulting in a value of true for the tDepth uniform:

Good finding! Assigning a boolean to tDepth wouldn't be right indeed!

I think the code is still a bit hard to read. Simply because the type of depthTexture changes from boolean to a texture. I guess I would rename the ctor parameter to useDepthTexture and declare depthTexture right before this code block:

three.js/examples/jsm/postprocessing/SAOPass.js

Lines 82 to 90 in 9bead8c

	if ( this.supportsDepthTextureExtension ) {
	depthTexture = new DepthTexture();
	depthTexture.type = UnsignedShortType;
	this.beautyRenderTarget.depthTexture = depthTexture;
	this.beautyRenderTarget.depthBuffer = true;
	}

What do you think?

[twastvedt]

I think the code is still a bit hard to read. Simply because the type of depthTexture changes from boolean to a texture. I guess I would rename the ctor parameter to useDepthTexture and declare depthTexture right before this code block

Totally agree. I was trying not to make waves, but I'll happily clean that up a bit.

[mrdoob]

Thanks!

[mrdoob]

Some additional clean up: db72a7d