Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frustum: Fix wrong test in split(). #22496

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Conversation

OndrejSpanel
Copy link
Contributor

Current condition i === breaks - 1 makes no sense. Apparently it should be breaks.length - 1, which would test for the last iteration.

@mrdoob mrdoob merged commit 5bfb2a9 into mrdoob:dev Sep 3, 2021
@mrdoob mrdoob added this to the r133 milestone Sep 3, 2021
@mrdoob
Copy link
Owner

mrdoob commented Sep 3, 2021

Thanks!

@OndrejSpanel OndrejSpanel deleted the patch-1 branch September 3, 2021 18:14
@mrdoob
Copy link
Owner

mrdoob commented Sep 6, 2021

/fyi @gkjohnson

@Mugen87 Mugen87 changed the title Fix wrong test in the frustum (missing .length) Frustum: Fix wrong test in split(). Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants