Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material: Use pseudo private variables. #22443

Merged
merged 3 commits into from
Aug 27, 2021
Merged

Material: Use pseudo private variables. #22443

merged 3 commits into from
Aug 27, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 27, 2021

Related issue: see #22437 (comment)

Description

The PR reverts the last two commits regarding rollup.config.js and introduces pseudo private variables in the material classes.

@Mugen87 Mugen87 requested a review from mrdoob August 27, 2021 10:19
@mrdoob mrdoob modified the milestones: 134, r133 Aug 27, 2021
@mrdoob mrdoob merged commit c487993 into mrdoob:dev Aug 27, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 27, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants