ShaderChunks: Ignore alpha in output_fragment when using NoBlending #22424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #15483 #18631 #21744 #22196 #22414
Description
This makes
NoBlending
behave as expected. Before this PRNoBlending
was writing alpha pixels when the framebuffer had an alpha channel.We can not use
NoBlending
to support GLTF'sOPAQUE
andMASK
alpha modes which was previously broken when settingalpha: true
inWebGLRenderer
.Here is an example with
alpha: true
andrenderer.domElement.style.backgroundColor = 'red'
:Note: I'm following a similar implementation to Khronos' GLTF Viewer:
/cc @elalish @donmccurdy