ShaderChunk: Turn alphaTest into a uniform (take 2) #22409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrdoob
changed the title
|
FYI the change with the private field breaks our build, It's kind of complicated to adjust our build setup, and three is a sub-dependency. |
|
Please follow #22437 for more information. |
|
Thank you @Mugen87 |
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #19803 (comment) #15654 #5623
Description
I think this has been proposed a few times. Should make programs more reusable.
/cc @donmccurdy @Mugen87 @WestLangley