ShadersChunk: Only use clearcoat chunks when clearcoat > 0 #22405
Conversation
| clearcoat: useClearcoat, | ||
| clearcoatMap: useClearcoat && !! material.clearcoatMap, | ||
| clearcoatRoughnessMap: useClearcoat && !! material.clearcoatRoughnessMap, | ||
| clearcoatNormalMap: useClearcoat && !! material.clearcoatNormalMap, |
There was a problem hiding this comment.
@WestLangley Should we do something like this for transmission too? If so... what parameters depend on material.transmision > 0?
There was a problem hiding this comment.
transmission: <float>,
transmissionMap: new THREE.Texture( <Image> ),
thickness: <float>,
thicknessMap: new THREE.Texture( <Image> ),
attenuationDistance: <float>,
attenuationTint: <Color>,There was a problem hiding this comment.
Excellent! I'll do that on my next PR.
There was a problem hiding this comment.
But actually, transmission and volume are separate extensions. The last four are for volume.
There was a problem hiding this comment.
Oh! But... in the context of our shader chunks, do thickness and attenuation affect the material if transmission is 0?
There was a problem hiding this comment.
Related: You can do something like this for sheenTint too, so the version will be incremented when sheenTint is changed from black to not-black.
Would love to see that. That would make the physical exclusive properties more consistent.
There was a problem hiding this comment.
So then the logic would be like this?
if ( transmision > 0 ) {
transmission: <float>
transmissionMap: new THREE.Texture( <Image> )
if ( thickness > 0 ) {
thickness: <float>
thicknessMap: new THREE.Texture( <Image> )
attenuationDistance: <float>
attenuationTint: <Color>
}
}There was a problem hiding this comment.
Yes, something like that.
There was a problem hiding this comment.
There should be USE_TRANSMISSION and USE_VOLUME.
It is up to you if USE_TRANSMISSION is used to mean "transmission_without_volume" -- a.k.a. thin surface only.
There was a problem hiding this comment.
Oh! But... in the context of our shader chunks, do thickness and attenuation affect the material if transmission is 0?
No.
Description
Currently
MeshPhysicalMaterialcomputed shader includes clearcoat chunks even whenmaterial.clearcoatis0. This PR solves that and does some additional clean up.