Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLTextures: Unbind textures with dedicated method. #22394

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 23, 2021

Related issue: -

Description

While debugging #22335, I've noticed that some code in WebGLTextures does not use the unbind() method for unbinding textures. This is not ideal since invalid state is produces which can lead to unnecessary bindings.

To be clear, the PR does not solve the rendering issue in #22335.

@mrdoob mrdoob added this to the r132 milestone Aug 23, 2021
@mrdoob mrdoob merged commit 57b7a9b into mrdoob:dev Aug 23, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 23, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants