Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong member name WebGLCubeUVMaps.onTextureDispose #22386

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

OndrejSpanel
Copy link
Contributor

The member name used in WebGLCubeUVMaps.onTextureDispose is wrong. It should be cubeUVmaps.delete(texture), not cubemapUV.delete(texture), which calls who knows what (if anything at all).

This is also confirmed by looking at similar WebGLCubeMaps.onTextureDispose:

			cubemaps.delete( texture );
			cubemap.dispose();

@Mugen87 Mugen87 added this to the r132 milestone Aug 21, 2021
@mrdoob mrdoob merged commit 4cc5598 into mrdoob:dev Aug 21, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants