-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MeshPhysicalMaterial: .sheen -> .sheenTint #22381
Conversation
Note: |
Thanks! |
#22379 (comment). I vote to keep |
We set optional material texture properties to
Same for |
The difference is that In other words changing the default value of |
That is not the user's concern. |
Don't get me wrong, I'm fine with your alternative approach. I just though because of #17700 (comment) we want to use |
Would it make sense to add a |
Personally, I think clearcoat should be named EDIT: ...but I do not have a strongly feeling about it. It is OK as-is.
Regarding sheenTint
sheenTintMap
sheenRoughness
sheenRoughnessMap Adding EDIT: In Version 2022x of the Dassault spec, |
To accommodate upcoming changes to
MeshPhysicalMaterial
,.sheen
is renamed to.sheenTint
.At a later time, additional properties will be added:
This nomenclature is consistent with the properties
.specularTint
and.attenuationTint
.sheenTint
is aTHREE.Color
. it is nevernull
.A new convenience methodTHREE.Color.isBlack()
is added which can be used to test for zero values.As per the glTF spec, the sheen layer is disabled when the color is black.