Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaders: material.specularRoughness -> material.roughness #22374

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Shaders: material.specularRoughness -> material.roughness #22374

merged 1 commit into from
Aug 20, 2021

Conversation

WestLangley
Copy link
Collaborator

This is isolated to the shaders, but there is no need to have two terms for the same thing.

We also have clearcoatRoughness, and in the future, sheenRoughness.

@WestLangley WestLangley added this to the r132 milestone Aug 19, 2021
@mrdoob mrdoob merged commit 4346e81 into mrdoob:dev Aug 20, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 20, 2021

Thanks!

@WestLangley WestLangley deleted the dev_shaders_roughness branch August 20, 2021 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r132
Development

Successfully merging this pull request may close these issues.
2 participants
@WestLangley @mrdoob