Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaders: renamed some more functions #22372

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Conversation

WestLangley
Copy link
Collaborator

getDirectionalDirectLightIrradiance() neither gets irradiance nor returns irradiance; it populates a data structure.

For lack of a better term, I think getDirectionalLightInfo() is reasonable for now.

@WestLangley WestLangley added this to the r132 milestone Aug 19, 2021
@mrdoob mrdoob merged commit f753126 into mrdoob:dev Aug 19, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 19, 2021

Thanks!

@WestLangley WestLangley deleted the dev_nomenclature2 branch August 19, 2021 17:47
0b5vr added a commit to pixiv/three-vrm that referenced this pull request Sep 10, 2021
0b5vr added a commit to pixiv/three-vrm that referenced this pull request Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants