Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uv transform support for transmission and thickness maps #22364

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Add uv transform support for transmission and thickness maps #22364

merged 1 commit into from
Aug 19, 2021

Conversation

zeux
Copy link
Contributor

@zeux zeux commented Aug 19, 2021

Before this change, when a material contained a transmission or thickness map with no other maps, UV transform on that map was implicitly disabled. This change hooks up these maps to the same first UV matrix we use for most textures since it would most often be mapped using the same layout as other material textures. Among other things this fixes thickness textures when using quantized coordinates outside of [0..1] range.

Before:
image

After:
image

cc @donmccurdy

@Mugen87 Mugen87 added this to the r132 milestone Aug 19, 2021
@mrdoob mrdoob merged commit 0632e04 into mrdoob:dev Aug 19, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 19, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants