Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLTFLoader: Fix cubicspline interpolation for quaternions. #22347

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 17, 2021

Related issue: Fixed #22339.

Description

From the glTF spec:

When the sampler targets a node's rotation property, the resulting p(t) quaternion must be normalized before applying the result to the node's rotation.

@Mugen87 Mugen87 requested a review from donmccurdy August 17, 2021 09:08
@mrdoob mrdoob added this to the r132 milestone Aug 17, 2021
@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 19, 2021

@donmccurdy I've implemented your feedback! Code looks now way simpler than before.

@mrdoob mrdoob merged commit 5fc904d into mrdoob:dev Aug 19, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 19, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GLTFLoader: Quaternions not normalized after cubic interpolation
4 participants