Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMREMGenerator: properly dispose of background material #22338

Merged
merged 1 commit into from
Aug 24, 2021
Merged

PMREMGenerator: properly dispose of background material #22338

merged 1 commit into from
Aug 24, 2021

Conversation

WestLangley
Copy link
Collaborator

PMREMGenerator does not dispose of the background material. This PR fixes that.

Review requested, please.

/ping @Mugen87
/ping @gkjohnson

@WestLangley WestLangley added this to the r132 milestone Aug 15, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 16, 2021

The change is good assuming _sceneToCubeUV() is not called per frame. Otherwise the previous approach would be more performant.

@WestLangley
Copy link
Collaborator Author

Thanks, guys!

@WestLangley
Copy link
Collaborator Author

@Mugen87 Maybe there is a better way to implement this?

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 23, 2021

The PR looks good to me!

@mrdoob mrdoob merged commit 07ec316 into mrdoob:dev Aug 24, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 24, 2021

Thanks!

@WestLangley WestLangley deleted the dev_pmrem_dispose branch August 24, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

@gkjohnson gkjohnson gkjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r132
Development

Successfully merging this pull request may close these issues.
4 participants
@WestLangley @Mugen87 @mrdoob @gkjohnson