Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMREMGenerator: Remove extra conversion to RGBE color #22327

Merged
merged 2 commits into from
Aug 14, 2021

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Aug 13, 2021

Related issue: Fixed #22326

Description

Remove unnecessary conversion to RGBE because it already implicitly happens in the shader. See #22326 (comment)

I'll likely need to update the screenshot but I'll have to do that later today.

cc @WestLangley @Mugen87

@Mugen87 Mugen87 added this to the r132 milestone Aug 14, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 14, 2021

Merging this for further testings on dev.

@Mugen87 Mugen87 merged commit 0d9045f into mrdoob:dev Aug 14, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 14, 2021

Updated builds: 33d11d8

@gkjohnson gkjohnson deleted the pmrem-color-fix branch August 15, 2021 14:08
@mrdoob
Copy link
Owner

mrdoob commented Aug 15, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PMREMGenerator.fromScene() is not using the correct background color
3 participants