Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshPhysicalMaterial: Support specular attenuation of environment maps #22319

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

WestLangley
Copy link
Collaborator

This is a follow-on to #22156.

.specularIntensity now attenuates all specular reflections.

.specularIntensity does not attenuate clearcoat, however. I think that is consistent with the glTF spec.

clearcoat is itself an attenuation parameter, so I think this is OK.

@WestLangley WestLangley added this to the r132 milestone Aug 12, 2021
@mrdoob mrdoob merged commit dab458f into mrdoob:dev Aug 12, 2021
@mrdoob
Copy link
Owner

mrdoob commented Aug 12, 2021

Thanks!

@WestLangley
Copy link
Collaborator Author

.specularIntensity does not attenuate clearcoat, however. I think that is consistent with the glTF spec.

Use case: a Lambertian surface with a clearcoat.

/ping @donmccurdy Does that sound OK to you?

@WestLangley WestLangley deleted the dev_physical_specular branch August 12, 2021 19:43
@donmccurdy
Copy link
Collaborator

This sounds like the right decision to me, but didn't find a clear answer in the clearcoat discussion section. @emackey we clarify that base IOR does not affect clearcoat, is it safe to say that KHR_materials_specular does not either?

@emackey
Copy link

emackey commented Aug 17, 2021

@emackey we clarify that base IOR does not affect clearcoat, is it safe to say that KHR_materials_specular does not either?

Yes. You're right that we don't explicitly state specular's lack of effect on clearcoat the way we do with IOR. But the result is the same: Clearcoat is an independent layer, not perturbed by any specular or IOR settings on the layer below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants